Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update CreateOrderFulfillmentWorkflowInput #9479

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

update CreateOrderFulfillmentWorkflowInput #9479

wants to merge 3 commits into from

Conversation

420coupe
Copy link
Contributor

@420coupe 420coupe commented Oct 4, 2024

Update CreateOrderFulfillmentWorkflowInput to have an optional requires_shipping?: boolean for creation of fulfillment for digital products.

@420coupe 420coupe requested a review from a team as a code owner October 4, 2024 18:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2f4599f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 4, 2024

@420coupe is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@420coupe
Copy link
Contributor Author

reason for this is to be able to createFulfillmentWorkFlows that do not require shipping, so have to modify the input to accept the optional variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@420coupe @carlos-r-l-rodrigues